Lift + shift for cross-db macros #25
Conversation
|
Functional tests are running, which is actually amazing. The other tests are running into a |
jtcohen6
force-pushed
the
jerco/utils-lift-shift
branch
from
10a0140 to
8f01640
Compare
jtcohen6
changed the title
|
The idea would be:
|
| pytest | ||
| pyodbc==4.0.32 | ||
| git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core | ||
| git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter | ||
| git+https://github.com/dbt-labs/dbt-spark.git#egg=dbt-spark[ODBC] |
| [pytest] | ||
| filterwarnings = | ||
| ignore:.*'soft_unicode' has been renamed to 'soft_str'*:DeprecationWarning | ||
| ignore:unclosed file .*:ResourceWarning | ||
| env_files = | ||
| test.env | ||
| testpaths = | ||
| tests/functional |
There was a problem hiding this comment.
Last Week I Learned (LWIL):
- By default
pytest-dotenvwill not override any variables already defined in the process' environment
Example
Let's say I have an environment variable defined locally:
DBT_DATABASE_HOST=localhost
And test.env contains:
DBT_DATABASE_HOST=somethingelse
By default, pytest-dotenv will keep the former and ignore the latter. Scroll down to see how to configure the opposite behavior.
Override default behavior
So it depending on how we want pytest + pytest-dotenv to behave, we either will want to include the following (or not!):
env_override_existing_values = 1
There was a problem hiding this comment.
A great LWIL!
This makes sense to me, insofar as I might have a test.env, but then also want to do:
export DBT_DATABASE_HOST=localhost
python3 -m pytest ...
I would indeed expect the env var I've just supplied to override the one in test.env
Follow-up to: